fix(cli): do not validate contexts in ado delete context#841
Merged
Conversation
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
michael-johnston
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the context deletion logic to remove unnecessary Pydantic validation and simplify the code by directly accessing YAML configuration values instead of validating the entire ProjectContext model.
Resolves #819
Files Changed
📄
orchestrator/cli/resources/context/delete.pySimplifies the context deletion flow by removing Pydantic model validation. Instead of validating the entire
ProjectContextmodel from the YAML file, the code now loads the YAML as a dictionary and usesget_nested_value()utility to directly access themetadataStore.schemefield. This removes the dependency onpydanticandProjectContextmodel, eliminates error handling for validation errors, and makes the code more lightweight since full model validation is unnecessary for the delete operation that only needs to check the database scheme type.