fix(vllm_performance): do not override env if existing in deployment template#896
Merged
Merged
Conversation
Member
Author
|
@mgazz please confirm it now works for you |
AlessandroPomponio
changed the title
AlessandroPomponio
changed the title
Member
|
Env vars processed as expected. 👍 |
mgazz
approved these changes
Apr 22, 2026
…oyment config Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
christian-pinto
force-pushed
the
cp_fix_vllm_deployment_env
branch
from
931e9d3 to
6da4953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actuator code is currently overriding the container env configuration even is something is already present int the deployment template. Instead, if something is the template we should just extend with any additional variable.
This PR fixes the above issue.