fix(cli): disable ray's uv run runtime env hook by default#905
Merged
Conversation
AlessandroPomponio
changed the title
Co-authored-by: Alessandro Pomponio <10339005+AlessandroPomponio@users.noreply.github.com> Signed-off-by: Michael Johnston <66301584+michael-johnston@users.noreply.github.com>
Signed-off-by: Michael Johnston <66301584+michael-johnston@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem
Ray’s
uv runintegration automatically packages the current working directory for workers (#506). While useful for distributed setups, it causes significant friction for local ado executions (uv run ado ...). It unnecessarily attempts to upload the source-tree plus untracked files to the local object store, leading to slow startup times and frequent failures in dev/agent workflows.Since
adoexplicitly manages remote environments viaado --remotethis automatic Ray hook is redundant for our default paths.Changes in this PR
os.environ.setdefault("RAY_ENABLE_UV_RUN_RUNTIME_ENV", "0")atadoentrypoints . This must happens beforerayis imported.export RAY_ENABLE_UV_RUN_RUNTIME_ENV=1.runtime_env={"working_dir": None}hack inray.init(). Newer Ray versions validate this as a path string, meaningNonenow raises aTypeError(bug(tests): unable to run tests with uv run due to none working dir #893 )