Skip to content

fix: Validate custom session timeout properly in client builder#46

Merged
alienzach merged 1 commit intomasterfrom
sess-timeout-fix
Dec 15, 2020
Merged

fix: Validate custom session timeout properly in client builder#46
alienzach merged 1 commit intomasterfrom
sess-timeout-fix

Conversation

@njhill
Copy link
Copy Markdown
Contributor

@njhill njhill commented Dec 14, 2020

Also add arg validation for a couple of other builder methods

Fixes #45

Also add arg validation for a couple of other builder methods

Fixes #45
Copy link
Copy Markdown
Contributor

@alienzach alienzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alienzach alienzach merged commit fde6c12 into master Dec 15, 2020
@njhill njhill deleted the sess-timeout-fix branch December 16, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In EtcdClient.forEndpoints(xxx).withSessionTimeoutSecs(); Why is the verification completely opposite after version 0.015;

2 participants