Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Conversation

@jpwsutton
Copy link
Member

@jpwsutton jpwsutton commented Jun 9, 2023


Status

READY

Description

This PR makes a few changes to the automated tests in ibm-generative-ai

  • Adds the example programs as part of the integration test suite
  • Modifies a few examples to prevent them from running indefinitely / a long time
  • Pushes Code coverage to coveralls
  • Refactors extension tests into their own directory and removes the need for individual pytest markings. Now all extension tests use the extension mark.

Impacted Areas in Library

  • GitHub Workflows
  • Extension tests
  • Integration Tests

Which issue(s) does this pull-request fix?

Closes: #22

Any special notes for your reviewer?


Checklist

  • Automated tests exist
  • Updated Package Requirements (if required, and with maintainers' approval)
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above
  • Link to relevant GitHub issue provided

Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
@jpwsutton jpwsutton force-pushed the examples-as-integration-tests branch from 3b53ccc to ff6a77b Compare June 9, 2023 13:03
Copy link
Member

@vedem1192 vedem1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jpwsutton jpwsutton linked an issue Jun 12, 2023 that may be closed by this pull request
Copy link
Member

@mirianfsilva mirianfsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM! :)

creds = Credentials(api_key, api_endpoint)
model = Model(ModelType.FLAN_UL2, params=params, credentials=creds)

prompt_path = pathlib.Path(__file__, "..", "prompts", "Country-Capital-Factual-QA").resolve()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@onkarbhardwaj
Copy link
Contributor

Approved and merging!

@onkarbhardwaj onkarbhardwaj merged commit c7a708f into IBM:develop Jun 14, 2023
moneill0 pushed a commit to moneill0/ibm-generative-ai that referenced this pull request Jun 26, 2023
…M#28)

---------

Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automated example testing on develop

4 participants