This repository was archived by the owner on Mar 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
feat: adding examples as part of integration tests and misc fixes #28
Merged
onkarbhardwaj
merged 3 commits into
IBM:develop
from
jpwsutton:examples-as-integration-tests
Jun 14, 2023
Merged
feat: adding examples as part of integration tests and misc fixes #28
onkarbhardwaj
merged 3 commits into
IBM:develop
from
jpwsutton:examples-as-integration-tests
Jun 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
3b53ccc to
ff6a77b
Compare
vedem1192
approved these changes
Jun 9, 2023
Member
vedem1192
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
mirianfsilva
approved these changes
Jun 13, 2023
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now LGTM! :)
| creds = Credentials(api_key, api_endpoint) | ||
| model = Model(ModelType.FLAN_UL2, params=params, credentials=creds) | ||
|
|
||
| prompt_path = pathlib.Path(__file__, "..", "prompts", "Country-Capital-Factual-QA").resolve() |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
onkarbhardwaj
approved these changes
Jun 14, 2023
Contributor
|
Approved and merging! |
moneill0
pushed a commit
to moneill0/ibm-generative-ai
that referenced
this pull request
Jun 26, 2023
…M#28) --------- Signed-off-by: James Sutton <james.sutton@uk.ibm.com> Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This PR makes a few changes to the automated tests in ibm-generative-ai
extensionmark.Impacted Areas in Library
Which issue(s) does this pull-request fix?
Closes: #22
Any special notes for your reviewer?
Checklist