Skip to content
This repository was archived by the owner on Nov 4, 2020. It is now read-only.

Comments

Fix performance killer, minor design changes to the cards#135

Merged
stevemar merged 1 commit intoIBM:masterfrom
Nitair:master
Jan 4, 2019
Merged

Fix performance killer, minor design changes to the cards#135
stevemar merged 1 commit intoIBM:masterfrom
Nitair:master

Conversation

@Nitair
Copy link

@Nitair Nitair commented Jan 4, 2019 •
edited
Loading

Summary

  • Fixes performance approx by ~30-40%
  • Browser doesn't hang that much, but it's still not smooth
  • Minor design changes of the text in the cards

-_-

Note: This will remove scrollable cards. This was the cause here.

stevemar
stevemar approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@stevemar stevemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm OK with this. if I have any questions/concerns I may bug you about it offline :)

@stevemar stevemar merged commit c85d5bf into IBM:master Jan 4, 2019
@Nitair
Copy link
Author

Nitair commented Jan 4, 2019

@stevemart Sure, same here. Never see you online lol

@stevemar
Copy link
Contributor

stevemar commented Jan 4, 2019

@Nitair i'm mostly on slack :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stevemar stevemar stevemar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nitair @stevemar