Skip to content

Repository Modernization Plan - Phase 2D: Add missing IDEMIX_ARIES to mspTypeStrings map#72

Merged
adecaro merged 1 commit into
IBM:mainfrom
Soumya8898:Soumya8898/phase2/fix-msp-provider
May 26, 2026
Merged

Repository Modernization Plan - Phase 2D: Add missing IDEMIX_ARIES to mspTypeStrings map#72
adecaro merged 1 commit into
IBM:mainfrom
Soumya8898:Soumya8898/phase2/fix-msp-provider

Conversation

@Soumya8898
Copy link
Copy Markdown
Contributor

Add missing IDEMIX_ARIES to mspTypeStrings map

Fixes #63

What

Adds the IDEMIX_ARIES provider type to the mspTypeStrings lookup map in msp/provider.go.

Why

The IDEMIX_ARIES constant was added to the ProviderType enum but the corresponding entry in mspTypeStrings was never added. The inline comment at the enum definition explicitly states: "as new types are added to this set, the mspTypes map below must be extended".

This means ProviderTypeToString(IDEMIX_ARIES) was returning "" instead of a meaningful identifier.

Change

// Before
var mspTypeStrings = map[ProviderType]string{
    FABRIC: "bccsp",
    IDEMIX: "idemix",
}

// After
var mspTypeStrings = map[ProviderType]string{
    FABRIC:       "bccsp",
    IDEMIX:       "idemix",
    IDEMIX_ARIES: "idemix-aries",
}

@Soumya8898 Soumya8898 force-pushed the Soumya8898/phase2/fix-msp-provider branch from 816d903 to fc6b275 Compare May 24, 2026 20:23
@Soumya8898 Soumya8898 force-pushed the Soumya8898/phase2/fix-msp-provider branch from fc6b275 to e3e9bb2 Compare May 25, 2026 20:49
@adecaro adecaro self-requested a review May 26, 2026 04:37
@adecaro adecaro self-assigned this May 26, 2026
@adecaro adecaro added the bug Something isn't working label May 26, 2026
Copy link
Copy Markdown
Member

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The mspTypeStrings map was missing the IDEMIX_ARIES provider type that
was added alongside the constant. The inline comment explicitly states
the map must be extended when new types are added.

Signed-off-by: Soumya Mohapatra <mohapatras@microsoft.com>
@adecaro adecaro force-pushed the Soumya8898/phase2/fix-msp-provider branch from e3e9bb2 to e837aff Compare May 26, 2026 04:38
@adecaro
Copy link
Copy Markdown
Member

adecaro commented May 26, 2026

Hi @Soumya8898 , great work, thanks a lot for the effort so far. Which are the next steps? 🙏

@Soumya8898
Copy link
Copy Markdown
Contributor Author

Hi @adecaro i commented on the issue thread only for #63, can you please check.

@adecaro adecaro merged commit d1dd4f2 into IBM:main May 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idemix Repository Modernization Plan

2 participants