Repository Modernization Plan - Phase 2D: Add missing IDEMIX_ARIES to mspTypeStrings map#72
Merged
Conversation
816d903 to
fc6b275
Compare
fc6b275 to
e3e9bb2
Compare
The mspTypeStrings map was missing the IDEMIX_ARIES provider type that was added alongside the constant. The inline comment explicitly states the map must be extended when new types are added. Signed-off-by: Soumya Mohapatra <mohapatras@microsoft.com>
e3e9bb2 to
e837aff
Compare
Member
|
Hi @Soumya8898 , great work, thanks a lot for the effort so far. Which are the next steps? 🙏 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing IDEMIX_ARIES to mspTypeStrings map
Fixes #63
What
Adds the
IDEMIX_ARIESprovider type to themspTypeStringslookup map inmsp/provider.go.Why
The
IDEMIX_ARIESconstant was added to theProviderTypeenum but the corresponding entry inmspTypeStringswas never added. The inline comment at the enum definition explicitly states: "as new types are added to this set, the mspTypes map below must be extended".This means
ProviderTypeToString(IDEMIX_ARIES)was returning""instead of a meaningful identifier.Change