Skip to content

feat(build): Regenerate API with KMIP Mgmt APIs#40

Merged
stephaniegalang merged 22 commits intoIBM:masterfrom
MDarmawan:kmipMgmt
Jun 24, 2024
Merged

feat(build): Regenerate API with KMIP Mgmt APIs#40
stephaniegalang merged 22 commits intoIBM:masterfrom
MDarmawan:kmipMgmt

Conversation

@MDarmawan
Copy link
Copy Markdown
Collaborator

@MDarmawan MDarmawan commented May 2, 2024 •
edited
Loading

Regenerated API with KMIP management APIs. This has caused some classes and method signatures to change.

The examples have now been moved to its own standalone runnable example maven project.

Added PR template

Detailed list of changes made

General changes (generally impacts how users would receive the return type, only two impacts method calling)

  • GetInstancePoliciesOneOf
  • Replaced field "metadata" type CollectionMetadata -> CollectionMetadataOneOf
  • GetMultipleKeyPoliciesResource
  • Removed getType() function
  • InstancePolicyAllowedIPPolicyData
  • Replaced field "attributes" type AllowedIPProperties -> InstancePolicyAllowedIPPolicyDataAttributes
  • InstancePolicyProperties
  • Replaced field "attributes" type InstancePolicyAllAttribute -> InstancePolicyProperties
  • Key
  • Replace field "metadata" type CollectionMetadata -> CollectionMetadataOneOf
  • KeyActionOneOfResponse
  • Replaced field "keyVersion" type KeyVersion -> WrappedKeyVersionKeyVersion
  • Replaced field "rewrappedKeyVersion" type KeyVersion -> RewrappedKeyVersionRewrappedKeyVersion
  • ListKeys
  • Replaced field "metadata" type CollectionMetadata -> CollectionMetadataListKeys
  • ListKeyVersions
  • Replace field "metadata" type CollectionMetadata -> ListCollectionMetadata
  • PutInstancePolicyOptions
  • Rename field + getter func "setInstancePoliciesOneOf" -> "instancePolicyPutBody"
  • PutPolicyOptions
  • Rename field + getter func "setKeyPoliciesOneOf" -> "keyPolicyPutBody"
  • RewrapKeyResponseBody
  • Replaced field "keyVersion" type KeyVersion -> WrappedKeyVersionKeyVersion
  • Replaced field "rewrappedKeyVersion" type KeyVersion -> RewrappedKeyVersionRewrappedKeyVersion
  • SetMultipleKeyPoliciesResource
  • Replaced field dualAuthDelete type "SetMultipleKeyPoliciesResourceDualAuthDelete" -> "KeyPolicyDualAuthDeleteDualAuthDelete"
  • Replaced field rotation type "SetMultipleKeyPoliciesResourceRotation" -> "KeyPolicyRotationRotation"
  • UnwrapKeyResponseBody
  • Replaced field "keyVersion" type KeyVersion -> WrappedKeyVersionKeyVersion
  • Replaced field "rewrappedKeyVersion" type KeyVersion -> RewrappedKeyVersionRewrappedKeyVersion
  • WrapKeyResponseBody
  • Replaced field "keyVersion" type KeyVersion -> WrappedKeyVersionKeyVersion

Removed files (and thus classes)

  • AddHeaderInterceptor
  • AllowedIPProperties
  • KeyCreateImportAccessProperties
  • KeyProtectException
  • KeyRepresentation
  • KeyRepresentationAlgorithmMetadata
  • NetworkPolicyAttribute
  • RetryInterceptor
  • RetryPolicy
  • SetMultipleKeyPoliciesResourceDualAuthDelete
  • SetMultipleKeyPoliciesResourceRotation
  • SetMultipleKeyPoliciesResourcesItem

Renamed files

  • GetKeyPoliciesOneOfResourcesItemDualAuthDelete
  • GetKeyPoliciesOneOfResourcesItemRotation
  • GetKeyPolicyRotationResourcesItemRotation
  • InstancePolicyAllAttributes
  • InstancePolicyResourceAllowedNetworkPolicy
  • ListKeyRings
  • NetworkPolicyProperties

@MDarmawan
autogenerated
42fcc35 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
use generics to fix mvn test problems
5107070 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan MDarmawan changed the title Regenerate API with KMIP Mgmt APIs feat(build): Regenerate API with KMIP Mgmt APIs May 29, 2024
MDarmawan added 4 commits May 30, 2024 11:39
@MDarmawan
regen for crk filter
ec7fe24 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
regenerate with correct openapi spec
27c8979 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
add generics fix back
8d52775 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
add examples
7693347 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
MDarmawan
MDarmawan commented Jun 5, 2024
View reviewed changes
Comment thread src/main/java/com/ibm/cloud/ibm_key_protect_api/v2/model/AllowedIPProperties.java
@@ -1,122 +0,0 @@
/*
Copy link
Copy Markdown
Collaborator Author

@MDarmawan MDarmawan Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have been replaced by the classInstancePolicyAllowedIPPolicyDataAttributes in where it appeared in the master branch.

MDarmawan added 14 commits June 5, 2024 10:51
@MDarmawan
regenerate spec without s2s calls
dd53282 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
redo generics fix
7c7f618 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
move kputils
c932fa0 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
add back a method deleted by autogen
ab7729f 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
working SDK examples
fa93894 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
finish KMIP examples
258a260 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
add kmip cert test
0f8db10 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
fix certs example
47b1e98 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
rename organize examples
b4020ba 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
add readme to examples
2c85161 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
format pom
55c72b0 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
readme add
bae74dd 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
add KMIP Adapter List CRK Filter
e1d3b3a 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
add PR template
2e06c13 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
Copy link
Copy Markdown
Collaborator Author

MDarmawan commented Jun 19, 2024

The travis in theory SHOULD publish to maven for us, but we'll have to make sure it does.

@MDarmawan
fix logging string
01d629f 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@MDarmawan
Copy link
Copy Markdown
Collaborator Author

MDarmawan commented Jun 24, 2024 

[main] INFO com.ibm.cloud.KeysExamples - Create a key
[main] INFO com.ibm.cloud.KeysExamples - Key with ID fb7601fc-9e79-4bb8-ad12-4f09923cfc49 created
[main] INFO com.ibm.cloud.KeysExamples - Get a key
[main] INFO com.ibm.cloud.KeysExamples - Got key with ID fb7601fc-9e79-4bb8-ad12-4f09923cfc49, key description is: created via sdk
[main] INFO com.ibm.cloud.KeysExamples - List keys
[main] INFO com.ibm.cloud.KeysExamples - key 1 ID is --> fb7601fc-9e79-4bb8-ad12-4f09923cfc49
[main] INFO com.ibm.cloud.KeysExamples - Delete a key
[main] INFO com.ibm.cloud.KeysExamples - Key with ID fb7601fc-9e79-4bb8-ad12-4f09923cfc49 deleted
[main] INFO com.ibm.cloud.KeysExamples - Restore a key
[main] INFO com.ibm.cloud.KeysExamples - Key with ID fb7601fc-9e79-4bb8-ad12-4f09923cfc49 restored
[main] INFO com.ibm.cloud.KeysExamples - Rotate a key
[main] INFO com.ibm.cloud.KeysExamples - Key with ID fb7601fc-9e79-4bb8-ad12-4f09923cfc49 rotated
[main] INFO com.ibm.cloud.KeysExamples - List key versions
[main] INFO com.ibm.cloud.KeysExamples - Version 1 of key is --> {
  "id": "0e482cac-e441-44fa-8674-dfbc9d2bce43",
  "creationDate": "2024-06-24T15:11:48.000Z"
}
[main] INFO com.ibm.cloud.KeysExamples - Version 2 of key is --> {
  "id": "fb7601fc-9e79-4bb8-ad12-4f09923cfc49",
  "creationDate": "2024-06-24T15:11:18.000Z"
}
[main] INFO com.ibm.cloud.KeysExamples - Delete the key
[main] INFO com.ibm.cloud.KeysExamples - Key with ID fb7601fc-9e79-4bb8-ad12-4f09923cfc49 deleted
[main] INFO com.ibm.cloud.KeysExamples - Purge a key
mdarmawan@Michaels-MBP-2 target % java -jar kp-sdk-example-1.0-SNAPSHOT.jar kmip
[main] INFO com.ibm.cloud.KMIPExample - Create a key
[main] INFO com.ibm.cloud.KMIPExample - Key with ID 55075e8c-e07a-4f35-896b-6e0301e1cc4a created
[main] INFO com.ibm.cloud.KMIPExample - Create a KMIP adapter
[main] INFO com.ibm.cloud.KMIPExample - KMIP adapter created with ID ac08b0ae-4553-43c4-97dd-ed5209d6e0e5
[main] INFO com.ibm.cloud.KMIPExample - Create a KMIP adapter
[main] INFO com.ibm.cloud.KMIPExample - KMIP client cert created with ID d01f9268-d71a-4276-8ed6-1a958f37d114
[main] INFO com.ibm.cloud.KMIPExample - Delete a KMIP adapter with ID ac08b0ae-4553-43c4-97dd-ed5209d6e0e5
[main] INFO com.ibm.cloud.KMIPExample - Delete a key
[main] INFO com.ibm.cloud.KMIPExample - Key with ID 55075e8c-e07a-4f35-896b-6e0301e1cc4a deleted```

Running a couple of the examples

@MDarmawan
refine PR template
eccec51 
Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com>
@stephaniegalang stephaniegalang merged commit 52c801e into IBM:master Jun 24, 2024
MDarmawan pushed a commit that referenced this pull request Jun 24, 2024
@semantic-release-bot
chore(release): 1.0.0 release notes
2ab7096 
# [1.0.0](0.2.4...1.0.0) (2024-06-24)

### Features

* **build:** Regenerate API with KMIP Mgmt APIs ([#40](#40)) ([52c801e](52c801e))

### Performance Improvements

* **build:** Add package.json for semantic release ([#44](#44)) ([0aeeeed](0aeeeed))
* **build:** remove some superfluous properties from example pom ([#41](#41)) ([cc293bd](cc293bd))
* **build:** update node version for sem-release ([#42](#42)) ([d7b96a5](d7b96a5))
* **build:** update semantic release job ([#43](#43)) ([19b174e](19b174e))

### BREAKING CHANGES

* **build:** update API spec caused classes and method signatures to change
* **build:** update API spec caused classes and method signatures to change
* **build:** update API spec caused classes and method signatures to change
* **build:** update to API spec caused classes and method signatures to change
@MDarmawan
Copy link
Copy Markdown
Collaborator Author

MDarmawan commented Jun 24, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephaniegalang stephaniegalang stephaniegalang approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MDarmawan @stephaniegalang