add NewZrFromUInt64 to instantiate a new Zr directly from a uint64 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Sorniotti <aso@zurich.ibm.com>
ale-linux
force-pushed
the
f-NewZrFromUInt64
branch
from
94004f7 to
4068b19
Compare
Collaborator
|
@adecaro A couple of minor changes - I thought I'd just do them because it was faster than leaving the comments. If you're happy with them, merge away! |
Member
Author
|
I still need your approval to the PR :) |
ale-linux
approved these changes
Dec 16, 2024
Collaborator
ale-linux
left a comment
ale-linux
left a comment
There was a problem hiding this comment.
LGTM - pls add tests though, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.