How to close itoolkit connection?

[abmusse]

Original report by Jesse G (Bitbucket: ThePrez, GitHub: ThePrez).

---

If I am using the iDb2Call transport, how does the connection get closed?

[abmusse]

@ThePrez Within istoredp.js After running the stored procedure seems the connection is disconnected and deleted.

So for each call to XML service stored procedure the connection will be opened & closed.

[abmusse]

After reviewing the code again I think we should call

• conn.close() - calls SQLFreeConnect
• stmt.close() - calls SQLFreeStmt

To ensure the connection and statement are freed properly.

Instead of using JavaScript delete keyword which is meant to remove properties from an object

[kadler]

Does a conn.close() not close all of its statements?

[abmusse]

Does a conn.close() not close all of its statements?

conn.close() makes a call to SQLFreeConnect which in the doc states:

SQLFreeConnect() invalidates and frees the connection handle. All DB2® for i CLI resources associated with the connection handle are freed.

@kadler

Does this imply that the statements attached to the connection will also be freed?

[kadler]

I don't think IBM i CLI frees any statement handles. The database resources associated with them may be implicitly freed, but the statements are still assigned and "valid". I'd suggest having the connection keep a reference to it's statement objects and closing them all in conn.close.

[abmusse]

That makes sense would need to implement this within idb-connector.

I can open an issue with the suggestion over at that repo for further discussion.

For now I suppose we should explicitly close the statement and connection with

stmt.close() - calls SQLFreeStmt
conn.disconn() - calls SQLDisconnect
conn.close() - calls SQLFreeConnect

[abmusse]

PR #42 reworks idb transport to clean up properly.

[abmusse]

Closing PR #42 adds cleanup for Connections.