fix(Context-Based Restrictions): add display name to service ref response #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pyrooka
changed the title
Signed-off-by: Dylan <Dylan.Yu@ibm.com>
JonahFarc
force-pushed
the
serviceref-fix
branch
from
35c3bc0 to
b8fe866
Compare
Contributor
Author
|
Integration Tests: Examples: |
pyrooka
requested changes
Jan 15, 2026
Member
pyrooka
left a comment
pyrooka
left a comment
There was a problem hiding this comment.
I think you need to rebase this PR onto the main branch. If you look at the commits you can see 3 that don't belong here: 2 release commits and one for the IAM Identity service. Please remove those from this PR just to make sure we won't mess up anything - even though it shouldn't cause an issue.
JonahFarc
force-pushed
the
serviceref-fix
branch
from
7dad793 to
d46a7f9
Compare
Contributor
Author
|
Re-ran tests for evidence: Examples: |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jan 15, 2026
## [0.73.1](0.73.0...0.73.1) (2026-01-15) ### Bug Fixes * **Context-Based Restrictions:** add display name to service ref response ([#290](#290)) ([dd2444e](dd2444e))
Contributor
|
🎉 This PR is included in version 0.73.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Adding missing property to service ref response
Also, auto-generation has a lot of cleanliness changes, going ahead and applying now to avoid future efforts.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Added display name to service ref response. No service should be dependent on it, but it is nice to have.
Does this PR introduce a breaking change?