Skip to content

SSI improvements#11

Merged
mandel merged 26 commits intoIBM:masterfrom
psg-mit:master
Aug 28, 2023
Merged

SSI improvements#11
mandel merged 26 commits intoIBM:masterfrom
psg-mit:master

Conversation

@ellieyhcheng
Copy link
Copy Markdown
Contributor

@ellieyhcheng ellieyhcheng commented Aug 4, 2023

Added more conjugate priors and distributions

@ellieyhcheng ellieyhcheng mentioned this pull request Aug 9, 2023
Closed
@gbdrt
Copy link
Copy Markdown
Collaborator

gbdrt commented Aug 10, 2023

Thanks a lot!
Is it a lot of work to add Student-T to ProbZelus distributions?
Otherwise we will probably forgot that it's in the semi-symb lib but not available yet in ProbZelus.

mandel
mandel approved these changes Aug 14, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mandel mandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great. I just added a few comments that would be good to address.

probzelus/inference/ds_naive_graph.ml
Comment on lines +213 to 216
| DSnaive_Marginalized (Dist_binomial _, _) -> KOthers
| DSnaive_Marginalized (Dist_beta_binomial _, _) -> KOthers
| DSnaive_Marginalized (Dist_negative_binomial _, _) -> KOthers
| DSnaive_Marginalized (( Dist_sampler _
Copy link
Copy Markdown
Collaborator

@mandel mandel Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to identify the distribution such that the Ds_high_level can find the conjugacy relation?

@mandel
Copy link
Copy Markdown
Collaborator

mandel commented Aug 14, 2023

Is it a lot of work to add Student-T to ProbZelus distributions?

Same question for Poisson.

ellieyhcheng and others added 24 commits August 15, 2023 14:29
@ellieyhcheng
Add ssi exp, div. Add binomial and beta-binomial and conjugate prior
1dbc754 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Add named variables
b8edf87 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Allowing nonconstant variance for gaussians
6379693 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Increment unnamed variables
d4094ef 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Interface for lt that just samples
4895b00 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Add Negative Binomial, Gamma, Exponential, Poisson distributions + se…
42873d3 
…mi-symbolic lt interface

Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
make pp aprox status prettier
287a54a 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Use loggamma for numerical stability
5b8682e 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Default status is exact if not hoisted
3e4bee5 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Remove accidental commit
6fbd92b 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Helper functions for SSI
f202a7c 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Add mixture SSI distribution and expose some SSI functions
9b16566 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Gaussian variance SSI
8e8a7f4 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Int addition
18ca8d0 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Bernoulli bernoulli
2334a8b 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Swap with parents bugfix
e3c52ae 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Owl t distribution
8f24143 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
only record approx status when needed
07f3f63 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Push inference plan edits to siren
d78b03f 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Sample
f140171 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Sample
e93fa26 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@gbdrt @ellieyhcheng
Ocaml 5 (IBM#9)
8ebe6e4 
* Compatibility fixes for for OCaml 5 and Mtime 2.0.0

Signed-off-by: Guillaume Baudart <guillaume.baudart@inria.fr>
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Minor nits
b3e4c0c 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Add student t distr + nits
081f193 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
ellieyhcheng and others added 2 commits August 15, 2023 17:29
@ellieyhcheng
Merge branch 'master' into master
b1ff554
@ellieyhcheng
Add function signature for student t
dcdf2be 
Signed-off-by: Ellie Cheng <ellieyhc@csail.mit.edu>
@ellieyhcheng
Copy link
Copy Markdown
Contributor Author

ellieyhcheng commented Aug 15, 2023

I've added the Student T distribution. Poisson distribution is already there.

mandel
mandel approved these changes Aug 28, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mandel mandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @ellieyhcheng!

@mandel
Copy link
Copy Markdown
Collaborator

mandel commented Aug 28, 2023

But it looks like there is a conflict that prevent the merge...

@ellieyhcheng
Copy link
Copy Markdown
Contributor Author

ellieyhcheng commented Aug 28, 2023

Do you have more information about what's the conflict? It's not showing it from my view, only "This branch has no conflicts with the base branch". It also says the fork is already synced with upstream.

@mandel mandel merged commit 9d7635e into IBM:master Aug 28, 2023
@mandel
Copy link
Copy Markdown
Collaborator

mandel commented Aug 28, 2023

Sorry, I have a conflict because I was on the "rebase" setting for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandel mandel mandel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ellieyhcheng @gbdrt @mandel