feat(consumer): warn on sustained partition retries#3535
Merged
Conversation
After a broker disconnect a partition consumer can sit retrying indefinitely. Each attempt's error is logged but nothing tells the operator the same partition is still failing ten retries later, so it's hard to tell a transient blip from a stuck partition. Bump child.retries on every backoff (it was only incremented when a BackoffFunc was configured) and log every 10 consecutive failures. Also note on ConsumeClaim that handlers should return when the session context is done; reading Messages() alone hangs while a partition keeps retrying. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a broker disconnect a partition consumer can sit retrying indefinitely. Each attempt's error is logged but nothing tells the operator the same partition is still failing ten retries later, so it's hard to tell a transient blip from a stuck partition.
Bump child.retries on every backoff (it was only incremented when a BackoffFunc was configured) and log every 10 consecutive failures.
Also note on ConsumeClaim that handlers should return when the session context is done; reading Messages() alone hangs while a partition keeps retrying.
We've had a few users complain about scenarios like this "I get EOF errors and then my consumers go silent and stop consuming any message until I restart my whole app", so try and make this clearer when its happening