feat(consumer): cap partition consumer retries#3539
Merged
Conversation
A partition consumer currently retries forever after a broker disconnect or other dispatch failure. A single stuck partition can thus keep the consumer-group session alive (no rebalance) while the application sees no messages. Add Consumer.Retry.Max as an opt-in maximum on the number of dispatch failures. When the max is hit the partition consumer sends ErrConsumerRetriesExhausted on its Errors channel and closes itself; inside a consumer group the deferred sess.cancel() then ends the session and triggers a fresh rejoin, picking up new metadata and a healthy broker. Defaults to 0 (unlimited) to keep existing behaviour. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partition consumer currently retries forever after a broker disconnect or other dispatch failure. A single stuck partition can thus keep the consumer-group session alive (no rebalance) while the application sees no messages.
Add Consumer.Retry.Max as an opt-in maximum on the number of dispatch failures. When the max is hit the partition consumer sends ErrConsumerRetriesExhausted on its Errors channel and closes itself; inside a consumer group the deferred sess.cancel() then ends the session and triggers a fresh rejoin, picking up new metadata and a healthy broker. Defaults to 0 (unlimited) to keep existing behaviour.