Conversation
Consolidate duplicated vLLM configuration (org, repo, commit SHA, LLM-D version) into a single defaults.env file sourced by shell scripts and parsed at compile time by Rust via include_str!. Replace the blind VLLM_USE_PRECOMPILED=1 in the image builder startup script with smart detection that checks wheels.vllm.ai for a matching precompiled wheel and falls back to source compilation, matching the logic already used in setup-dev.sh. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
starpit
force-pushed
the
feat/shared-defaults-precompiled-wheel
branch
from
8987d40 to
e48ea61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/vllm/llm-d/defaults.envas a single source of truth for vLLM config (org, repo, commit SHA, LLM-D version), replacing duplicated values across shell scripts and Rust codegenpatch.shandclone.shto sourcedefaults.envinstead of hardcoding valuesdefaults.envat compile time viainclude_str!forImageCreateArgs(image builder) andGceConfig(dev VM) defaultsVLLM_USE_PRECOMPILED=1in the image builder startup script with smart detection that checkswheels.vllm.aifor a matching precompiled wheel and falls back to source compilationvllm_precompiled_wheel_commitfield toImageCreateArgs, included in the image name hash since it affects the resulting binariesTest plan
cargo build -F gcecompilescargo test -F gce— all 63 tests pass, including newtest_defaults_env_parsing,test_image_create_args_defaults_from_env, andtest_vllm_defaults_match_defaults_envbash -n genpatch.sh && bash -n clone.sh— shell scripts parse correctly🤖 Generated with Claude Code