perf: reduce unnecessary heap allocations in core paths#886
Merged
Conversation
- Return &str from Message::content() instead of cloning a String - Replace splitn().collect::<Vec<_>>() with split_once() for model routing - Fix pad() in tokenize to mutate in-place instead of cloning/rebuilding - Return &GenerateMetadata from Spec::metadata() instead of cloning - Use Cow::Borrowed in TreeItem::children() for vector Query variants Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Message::content() -> &str: Eliminates aStringclone on every call — heavily used in chat template formatting (N allocations per template application)split_once('/')for model routing: Replacessplitn(2, '/').collect::<Vec<_>>()with zero-allocationsplit_oncein bothgenerate()andmap()pad()mutates in-place: Removes a spurious.clone()of an already-ownedVec<u32>and replaces.collect()rebuild with in-placepop/extend/pushSpec::metadata() -> &GenerateMetadata: Returns a reference instead of cloning the entire structCow::BorrowedforTreeItem::children(): Avoids deep-cloning the child vector forPar/Seq/Plus/Crossvariants during tree printingTest plan
cargo checkwith default featurescargo check -p spnl --features tokcargo check -p spnl --features spnl-apicargo test -p spnl— 33/33 passcargo test -p spnl --features tok— 41/41 pass🤖 Generated with Claude Code