feat(gce): add --force flag to vllm down to ignore not-found errors#887
Merged
feat(gce): add --force flag to vllm down to ignore not-found errors#887
Conversation
starpit
force-pushed
the
feat/vllm-down-force
branch
from
38be02b to
d3ddfe2
Compare
When tearing down a GCE instance that may not exist (e.g. in CI cleanup with `if: always()`), the command now accepts -f/--force to treat "not found" errors as success rather than failing the workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
starpit
force-pushed
the
feat/vllm-down-force
branch
from
d3ddfe2 to
45530c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-f/--forceflag tospnl vllm downthat treats "not found" errors as success (instance already gone)NOT_FOUNDandUNKNOWNerror codes)vllm-gce.ymlCI workflow to use--forcein theif: always()cleanup stepTest plan
cargo check --features gcepassesspnl vllm down --force --target=gce <nonexistent>exits 0spnl vllm down --target=gce <nonexistent>still errors without--forcespnl vllm down --force --target=gce <existing>still deletes normally🤖 Generated with Claude Code