Add VARCHAR ↔ TIMESTAMPUTC cast support#1992
Open
Mariamalmesfer wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Hi @rui-mo, can you take a look at this? If it looks good, I have a draft corresponding Gluten PR ready to open. apache/gluten#12066 |
This was referenced May 12, 2026
rui-mo
reviewed
May 13, 2026
rui-mo
left a comment
rui-mo
left a comment
There was a problem hiding this comment.
Please extend the implementation in https://github.com/facebookincubator/velox/blob/main/velox/expression/CastExpr.h to support VARCHAR <-> TIMESTAMP, rather than introducing a custom cast function. Also, please open two separate PRs in Meta/Velox.
| } // namespace | ||
|
|
||
| void registerTimestampUtcCasts() { | ||
| registerCustomType( |
There was a problem hiding this comment.
Timestamp UTC is not a custom type, but a basic type. Please do not follow the TimestampNTZ type implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CastOperator for TimestampUtcType. Supports casting from/to VARCHAR — parsing ignores timezone in the input string and formatting skips session timezone. Registered through CustomTypeFactory under "TIMESTAMP UTC".