Fix crash when special tokens aren't found in model config.#60
Merged
Conversation
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
tdoublep
pushed a commit
that referenced
this pull request
Jan 20, 2025
This PR applies lint checks to the repository as done in the upstream vLLM repository. ### Changes: - removed unused imports with autoflake: `autoflake --remove-all-unused-imports --in-place <file>` - applied lint check to the current repo (`bash format.sh`) - added files for automatic link check for PRs to the `main` branch of our internal fork (added 4 files to `.github/workflows`) The code has been tested in client/server mode for the `llama 194m` and `granite 3b` on `AIU` and `CPU`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some models such as
sentence-transformers/all-MiniLM-L12-v2don't have special tokens such as "bos_token" in their tokenizer configuration. This causes a key error when the warmup logic tries to get the id for these tokens. However, since the IDs are only used to exclude them from the set of tokens that can be generated during the warmup, it doesn't make a difference if they don't exist.