Skip to content

Conversation

@anna-singleton
Copy link
Contributor

intended as a very basic example, somewhat of a jumping off point

Signed-off-by: Anna Singleton annabeths111@gmail.com

intended as a very basic example, somewhat of a jumping off point

Signed-off-by: Anna Singleton <annabeths111@gmail.com>
Copy link
Collaborator

@liyancn liyancn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function only servers on single jobs, but not considered array jobs, (bsub -J "a[1-10]")

2 suggestions:

  1. add considerration of single jobs
  2. rename single_job_info.py and give comments that do not try to use for array jobs.

@anna-singleton
Copy link
Contributor Author

thanks for your suggestions, since its intended to be a simple example, i've done the 2nd option. let me know if you have any other thoughts.

Signed-off-by: anna-singleton <annabeths111@gmail.com>
@liyancn
Copy link
Collaborator

liyancn commented Dec 7, 2022

thanks for your suggestions, since its intended to be a simple example, i've done the 2nd option. let me know if you have any other thoughts.

Thank you for the exclamation, it should help to avoid some misunderstanding.
/lgtm

@liyancn liyancn merged commit 43deda2 into IBMSpectrumComputing:master Dec 7, 2022
@anna-singleton anna-singleton deleted the jobinfo-example branch December 8, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants