Qbits tests (round 4) #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimnel
commented
Apr 9, 2025
Contributor
Author
|
Need to test that one can pass |
rajarshitiwari
approved these changes
Apr 10, 2025
Collaborator
rajarshitiwari
left a comment
rajarshitiwari
left a comment
There was a problem hiding this comment.
Go ahead with these changes.
| Let x1, x2, x3 be the vectors describing the positions of the three | ||
| qubits. Then we calcule the angle between x1-x2 and x3-x2. | ||
| """ | ||
| return self.get_angles([[a1, a2, a3]], mic=mic)[0] |
Collaborator
There was a problem hiding this comment.
See if in the original ASE, a1, a2, a3 were only treated as integer indices, or did it support them as Atom object as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for:
All part of #26