fix(asr-worker): fix inference on audios as embedded documents#21
Merged
fix(asr-worker): fix inference on audios as embedded documents#21
Conversation
735abbe to
3f41bc7
Compare
3f41bc7 to
d9d214f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inference on embedded documents failed because the
Document.pathof these documents is actually the path of the parent/root document.In practice these files are located under:
artifact_dir/project/id[0:2]/id[2:4]/rawHowever inference can't run on file without extension because the file extension is used to handler file conversion into the inference file format.
Hence when running inference on embedded document we create a symlink to the original document with the proper file extension.
Changes
asr-workerFixed
datashare-pythonAdded
FilesystemDocumentobject to reprensent a DS doc which can be stored on the original filesystem, stored as an artifact or copied into a workdir by a workerartifacts_root,workdir,docs_roottoWorkerConfigChanged
activity_contextual_idto be less verbose (only log wf info by default)