Skip to content

⚠️ feature(datashare-python): worker logging#30

Merged
ClemDoum merged 3 commits intomainfrom
feature(datashare-python)/logging
Apr 23, 2026
Merged

⚠️ feature(datashare-python): worker logging#30
ClemDoum merged 3 commits intomainfrom
feature(datashare-python)/logging

Conversation

@ClemDoum
Copy link
Copy Markdown
Contributor

@ClemDoum ClemDoum commented Apr 22, 2026

⚠️ breaking PR (worker configuration)

Description

Add support for worker logs with temporal information as context: activity_type, activity_id, activity_run_id, workflow_type, workflow_id, workflow_run_id and worker_id

Changes

datashare-python

Added

  • update work start script to log from module of all of they discovered elements

Changed

  • improved WorkerConfig log configuration by letting devs set per package log level through LoggingConfig

asr-worker

Added

  • added some informative logs to help debug

@ClemDoum ClemDoum force-pushed the feature(datashare-python)/logging branch 2 times, most recently from ec1c7e9 to 4e1e23e Compare April 22, 2026 11:55
@ClemDoum ClemDoum changed the title Feature(datashare python)/logging feature(datashare-python): worker logging Apr 22, 2026
@ClemDoum ClemDoum force-pushed the feature(datashare-python)/logging branch 2 times, most recently from ef5f813 to 8a42fa6 Compare April 22, 2026 12:35
@ClemDoum ClemDoum marked this pull request as ready for review April 22, 2026 12:36
@ClemDoum ClemDoum requested a review from winsomeglint April 22, 2026 12:36
@ClemDoum ClemDoum self-assigned this Apr 22, 2026
@ClemDoum ClemDoum changed the title feature(datashare-python): worker logging ⚠️ feature(datashare-python): worker logging Apr 22, 2026
@ClemDoum ClemDoum force-pushed the feature(datashare-python)/logging branch from 8a42fa6 to cd56bd7 Compare April 22, 2026 12:41
@ClemDoum ClemDoum merged commit 028e0ed into main Apr 23, 2026
8 checks passed
@ClemDoum ClemDoum deleted the feature(datashare-python)/logging branch April 23, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant