Skip to content

[BBT#541] A new way to install the internal headers#322

Merged
abouteiller merged 3 commits intoICLDisco:masterfrom
bosilca:topic/new_install
Mar 3, 2022
Merged

[BBT#541] A new way to install the internal headers#322
abouteiller merged 3 commits intoICLDisco:masterfrom
bosilca:topic/new_install

Conversation

@bosilca
Copy link
Copy Markdown
Contributor

@bosilca bosilca commented Mar 2, 2022

https://bitbucket.org/icldistcomp/parsec/pull-requests/541

Move the install directive in the corresponding CMake file.

Clean the install and the usage of PaRSEC as an internal or external project.

The other 2 commits were minor cleanups to remove typos and compiler warnings.

bosilca added 2 commits March 2, 2022 00:07
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
@bosilca bosilca marked this pull request as draft March 2, 2022 05:13
@bosilca bosilca changed the title Topic/new install [BBT#541] A new way to install the internal headers Mar 2, 2022
@bosilca bosilca force-pushed the topic/new_install branch from c6f7aa7 to cca0d34 Compare March 2, 2022 20:11
@bosilca bosilca requested review from abouteiller and devreal March 2, 2022 20:27
Comment thread parsec/CMakeLists.txt Outdated
@bosilca bosilca force-pushed the topic/new_install branch from cca0d34 to 7e784f1 Compare March 2, 2022 21:13
@bosilca bosilca marked this pull request as ready for review March 2, 2022 21:14
Copy link
Copy Markdown
Contributor

@abouteiller abouteiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested, just read through

Comment thread parsec/CMakeLists.txt Outdated
Comment thread parsec/interfaces/dtd/CMakeLists.txt Outdated
Comment thread parsec/CMakeLists.txt
Comment thread parsec/CMakeLists.txt
Clean the install and the usage of PaRSEC as an internal or external
project.

Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
@bosilca bosilca force-pushed the topic/new_install branch from 7e784f1 to 7146faf Compare March 2, 2022 22:31
@abouteiller abouteiller merged commit 9f9b36f into ICLDisco:master Mar 3, 2022
@bosilca bosilca deleted the topic/new_install branch March 24, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants