Profiling msync and header commit#337
Merged
bosilca merged 2 commits intoICLDisco:masterfrom Mar 22, 2022
Merged
Conversation
therault
force-pushed
the
profiling-msync-and-header-commit
branch
2 times, most recently
from
41c13ed to
c9565ea
Compare
for testing large profile generation.
…normal interruptions. The reader will only open files that contain a specific string (PARSEC_PROFILE_MAGICK) at a specific position in the header of a binary profile file. Move the setting of that string into the header from the initialization of the file to after the file is consistent. This way, if the process is aborted and the file is only partially written, the reader will refuse to open it.
therault
force-pushed
the
profiling-msync-and-header-commit
branch
from
c9565ea to
153aafd
Compare
abouteiller
approved these changes
Mar 10, 2022
bosilca
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #334