Clean strings usages in CMake.#340
Merged
bosilca merged 1 commit intoICLDisco:masterfrom Mar 11, 2022
Merged
Conversation
devreal
reviewed
Mar 10, 2022
bosilca
force-pushed
the
fix/protect_string_compare
branch
from
5e30f4d to
15885e0
Compare
devreal
reviewed
Mar 11, 2022
abouteiller
reviewed
Mar 11, 2022
Contributor
abouteiller
left a comment
abouteiller
left a comment
There was a problem hiding this comment.
There is also an instance in FindCython that got missed
bosilca
force-pushed
the
fix/protect_string_compare
branch
from
15885e0 to
5a76766
Compare
devreal
approved these changes
Mar 11, 2022
bosilca
force-pushed
the
fix/protect_string_compare
branch
from
5a76766 to
a6f4878
Compare
When we compare a CMake variable to a string, there is no need to pass
it as a string (aka "${}"), we can just use it directly as a named
variable.
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
fix/protect_string_compare
branch
from
a6f4878 to
a6edfea
Compare
devreal
reviewed
Mar 11, 2022
devreal
approved these changes
Mar 11, 2022
abouteiller
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we compare a CMake variable to a string, there is no need to pass
it as a string (aka "${}"), we can just use it directly as a named
variable.
Signed-off-by: George Bosilca bosilca@icl.utk.edu