Fallback using a compatible HWLOC.#341
Merged
abouteiller merged 2 commits intoICLDisco:masterfrom Mar 14, 2022
Merged
Conversation
bosilca
force-pushed
the
fix/hwloc_detection
branch
2 times, most recently
from
f343238 to
dd82591
Compare
abouteiller
approved these changes
Mar 13, 2022
therault
approved these changes
Mar 14, 2022
bosilca
force-pushed
the
fix/hwloc_detection
branch
from
bf32609 to
b8482b7
Compare
If the MPI provides HWLOC and it conflicts with the HWLOC version installed by default on the system, we were not correctly detecting the right HWLOC version to use. With this patch, if HWLOC_DIR is not specified we will try to use the MPI provided HWLOC first, if any. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
fix/hwloc_detection
branch
from
b8482b7 to
b0a1ca0
Compare
…tection Signed-off-by: Aurélien Bouteiller <bouteill@icl.utk.edu>
abouteiller
force-pushed
the
fix/hwloc_detection
branch
from
b0a1ca0 to
d9d55d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the MPI provides HWLOC and it conflicts with the HWLOC version installed by
default on the system, we were not correctly detecting the right HWLOC version
to use. With this patch, if HWLOC_DIR is not specified we will try to use the
MPI provided HWLOC first, if any.
In the same commit I tried to cleanup our usage of _ROOT and _DIR. HWLOC_ROOT is provided by the upper layer as a mean to direct the search process, while HWLOC_DIR is set by the detection itself to facilitate subsequent searches. HWLOC_ROOT is input only, while HWLOC is output only and cached.
Signed-off-by: George Bosilca bosilca@icl.utk.edu