Handle error in CUDA/HIP module init and configurable max_streams#351
Merged
bosilca merged 2 commits intoICLDisco:masterfrom Jun 16, 2022
Merged
Handle error in CUDA/HIP module init and configurable max_streams#351bosilca merged 2 commits intoICLDisco:masterfrom
bosilca merged 2 commits intoICLDisco:masterfrom
Conversation
abouteiller
approved these changes
Mar 17, 2022
bosilca
reviewed
Mar 17, 2022
abouteiller
approved these changes
Jun 9, 2022
bosilca
reviewed
Jun 10, 2022
Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
abouteiller
force-pushed
the
cuda-graceful-failure
branch
from
46a39f9 to
5096959
Compare
abouteiller
changed the title
abouteiller
changed the title
bosilca
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A misconfiguration on leconte makes none of the device capable of allocating a cuda stream.
This leads to a SEGFAULT, because we try to free things that have not been allocated.
With this patch, the devices are just removed (with a warning), but the execution proceeds.