Fix atomics on macosX not working properly (missing header)#356
Merged
bosilca merged 4 commits intoICLDisco:masterfrom Mar 28, 2022
Merged
Fix atomics on macosX not working properly (missing header)#356bosilca merged 4 commits intoICLDisco:masterfrom
bosilca merged 4 commits intoICLDisco:masterfrom
Conversation
bosilca
approved these changes
Mar 22, 2022
Also, the conditional for using 128bit atomics must be on the CAS128 capability, not the availability of int128_t (many platforms have the int128, but not the CAS128) Signed-off-by: Aurélien Bouteiller <bouteill@icl.utk.edu>
even when hwloc is available (as hwloc_bind doesn't work on OSX), this restores capability of binding on OS-X (to some extent, default configurations will work as expected, setting explicit vpmap params on OSX will generate warnings about not respecting the binding) Signed-off-by: Aurélien Bouteiller <bouteill@icl.utk.edu>
compilers of interest. Signed-off-by: Aurélien Bouteiller <bouteill@icl.utk.edu>
Signed-off-by: Aurélien Bouteiller <bouteill@icl.utk.edu>
abouteiller
force-pushed
the
bugfix/atomics-osx-ppc
branch
from
31a5dbf to
f1ffb58
Compare
bosilca
approved these changes
Mar 25, 2022
devreal
reviewed
Mar 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix atomics on macosX not working properly (missing header): we now fallback to using gcc-builtins if we don't have c11; all modern OSX compilers have them, so we removed the macosx specific atomics altogether.
Removes the PARSEC_OSX parsec_config.h define and use
__APPLE__insteadChange bind thread logic so that we use the OSX specific thread binding by default (even when we have hwloc, because hwloc binding doesn't work on OSX), issue some warning messages if user tries to change default behavior, as the backend doesn't have these capabilities.
Also, the conditional for using 128bit atomics must be on the CAS128 capability, not the availability of int128_t (many platforms have the int128, but not the CAS128). Having a single downstream variable rather than an upstream conditional avoids making mistakes and configurations that are non-workable.
(this is not a fix for the error with c11 atomics on gcc-11.2 osx, I just stumbled upon this problem when forcing other atomic modes for testing)