Don't pass the execution stream around to recursive calls.#413
Merged
bosilca merged 1 commit intoICLDisco:masterfrom Aug 11, 2022
Merged
Conversation
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
therault
approved these changes
Aug 10, 2022
devreal
approved these changes
Aug 10, 2022
Contributor
devreal
left a comment
There was a problem hiding this comment.
LGTM although I am not sure I grasp what recursive tasks are ^^
Contributor
|
Whoops, you call Edit: that's a nicer API, but much more annoying from the user perspective, since every caller needs to get Edit 2: wait, I'm silly, it's already being passed @@ -72,7 +70,7 @@ parsec_recursivecall( parsec_execution_stream_t *es,
parsec_taskpool_set_complete_callback( tp, &parsec_recursivecall_callback,
(void *)cbdata );
- parsec_context_add_taskpool( es->virtual_process->parsec_context, tp);
+ parsec_context_add_taskpool( task->taskpool->context, tp );
return -1;
} |
abouteiller
added a commit
to abouteiller/parsec
that referenced
this pull request
Aug 12, 2022
Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
omor1
added a commit
to uiuc-hpc/parsec
that referenced
this pull request
Aug 17, 2022
PR ICLDisco#413 fixed issues around recursive tasks by retrieving the current execution stream via `parsec_my_execution_stream`. However, under some circumstances, it appears that the `on_complete` callback can be called from the communication thread. The comm thread never sets the TLS variable needed for `parsec_my_execution_stream`, so you end up with a NULL execution stream and everything breaks. Ensure that `parsec_tls_execution_stream` is set by the communication thread as well. This introduces a new internal API to do so, `parsec_set_my_execution_stream`, since `parsec_tls_execution_stream` is a static variable in parsec.c. Signed-off-by: Omri Mor <omrimor2@illinois.edu>
omor1
added a commit
to uiuc-hpc/parsec
that referenced
this pull request
Aug 17, 2022
PR ICLDisco#413 fixed issues around recursive tasks by retrieving the current execution stream via `parsec_my_execution_stream`. However, under some circumstances, it appears that the `on_complete` callback can be called from the communication thread. The comm thread never sets the TLS variable needed for `parsec_my_execution_stream`, so you end up with a NULL execution stream and everything breaks. Ensure that `parsec_tls_execution_stream` is set by the communication thread as well. This introduces a new internal API to do so, `parsec_set_my_execution_stream`, since `parsec_tls_execution_stream` is a static variable in parsec.c. Signed-off-by: Omri Mor <omrimor2@illinois.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @omor1 for the bug report.
Fixes #412.
Signed-off-by: George Bosilca bosilca@icl.utk.edu