Remove startup tasks from DTD#425
Merged
bosilca merged 2 commits intoICLDisco:masterfrom Aug 27, 2022
Merged
Conversation
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Contributor
|
This is indeed a part among the goodies of #323, but we can merge it as a standalone effort, and I will update my branch. |
bosilca
approved these changes
Aug 19, 2022
abouteiller
approved these changes
Aug 22, 2022
| { | ||
| parsec_termdet_user_trigger_monitor_t *monitor; | ||
| assert(&parsec_termdet_user_trigger_module.module == tp->tdm.module); | ||
| assert(NULL == tp->tdm.monitor); |
Contributor
There was a problem hiding this comment.
should this be reinstated or removed?
Contributor
Author
There was a problem hiding this comment.
The patch says to remove it
Contributor
There was a problem hiding this comment.
no the patch comments it line below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only commits from the 'various' set of commits in parsec-ttg that have not been merged into master yet.
I believe there is another branch/PR with a larger set of cleanup for DTD, so maybe we just want to drop this.