Fix: termination detector race condition#438
Merged
bosilca merged 1 commit intoICLDisco:masterfrom Nov 1, 2022
Merged
Conversation
devreal
reviewed
Nov 1, 2022
|
|
||
| #if defined(PARSEC_DEBUG_PARANOID) | ||
| #define PARSEC_RWLOCK_UNLOCKED { PARSEC_ATOMIC_UNLOCKED, PARSEC_ATOMIC_UNLOCKED, 0, 0 } | ||
| #define PARSEC_RWLOCK_UNLOCKED PARSEC_ATOMIC_UNLOCKED, PARSEC_ATOMIC_UNLOCKED, 0, 0, |
Contributor
There was a problem hiding this comment.
This change seems to unintended. Didn't we just make the change to add the brackets to the PARSEC_RWLOCK_UNLOCKED?
Contributor
Author
There was a problem hiding this comment.
Fixed (and applied the same changes to the non-debug-paranoid case)
therault
force-pushed
the
fixes/termdet-fourcounter
branch
from
9b28c25 to
80b139e
Compare
therault
force-pushed
the
fixes/termdet-fourcounter
branch
from
80b139e to
cf8629a
Compare
bosilca
approved these changes
Nov 1, 2022
Contributor
|
Please update the commit log to identify the original commit that was cherry-picked. |
devreal
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of fixes made in TESSEOrg/parsec fork. There is a race condition in the termination detector that tries to free the monitor too early. The solution consists in adding an explicit 'unmonitor taskpool' function in the termination detector API and wait that the taskpool is destroyed / recycled to unmonitor the taskpool. This should help solve the issues in the taspool_wait PR too.