Fix statistics management with multiple GPU.#454
Merged
bosilca merged 1 commit intoICLDisco:masterfrom Nov 10, 2022
Merged
Conversation
therault
approved these changes
Nov 10, 2022
devreal
approved these changes
Nov 10, 2022
The data_in_array_size was initialized using parsec_nb_devices, but that variable is not constant until all the devices have been added to a context. Thus, each module was having statistics arrays with different sizes. This patch delays the statistics arrays allocation until the end of the device registration, a moment where we know how many devices are overall. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
fix/multi_gpu_446
branch
from
a651734 to
80ad489
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data_in_array_size was initialized using parsec_nb_devices, but that variable is not constant until all the devices have been added to a context. Thus, each module was having statistics arrays with different sizes. This patch delays the statistics arrays allocation until the end of the device registration, a moment where we know how many devices are overall.
Fixes #446