DSL profiling#469
Merged
bosilca merged 11 commits intoICLDisco:masterfrom Jan 27, 2023
Merged
Conversation
bosilca
reviewed
Jan 5, 2023
| parsec = parsec_init(-1, &pargc, &pargv); | ||
| assert( NULL != parsec ); | ||
|
|
||
| #if defined(PARSEC_PROF_TRACE) |
Contributor
There was a problem hiding this comment.
Why are we explicitly calling parsec_profiling_start in user-land ?
a buffer size limit, the code would wrongly terminate
…a a user-defined function; extend the parsec task class to take a DSL-defined function to log the beginning and end of a task; use this DSL-defined function in the task profiling macro
the event should also trace the additional info; In PINS task_profiler, only trace additional info once per task (after the completion of the task, so we get potential updates of the state of the task);
therault
force-pushed
the
dsl-profiling
branch
from
ebe97d5 to
8f72eda
Compare
Closed
Contributor
|
From #428:
Ideally, PTG would implement this for recursive tasks, so the user doesn't need to write it each time. |
bosilca
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the DSL to define its own task structure information. For TTG and for DTD, the additional parameters are not necessarily consecutive inside the locals, and/or not necessarily in a single block of memory (for TTG in particular). The proposed solution consists in exposing the logging buffer to a callback, and the DSL-specific callback writes what needs to be written inside the buffer, instead of requiring it to put all the data in a contiguous temporary memory that is then copied into the log buffer.
This is the second PR that is required to get all features of TTG ported on top of PaRSEC master. Please have a look / review.