Fix the branching test in distributed#495
Merged
bosilca merged 1 commit intoICLDisco:masterfrom Feb 21, 2023
Merged
Conversation
In DPLASMA, JDFs do not use the default type, and they use an external arena_datatype storage to support LAPACK+Tile format and datatype caching... However that doesn't mean that arena datatypes can be simply inherited from the data! Also fix the exit condition to work in distributed for branching.
bosilca
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still need to create the default arena datatype!
In DPLASMA, JDFs do not use the default type, and they use an external arena_datatype storage to support LAPACK+Tile format and datatype caching... However that doesn't mean that arena datatypes can be simply inherited from the data!
Also fix the exit condition to work in distributed for branching.