Skip to content

Profiling corrected.#526

Merged
bosilca merged 2 commits intoICLDisco:masterfrom
josephjohnjj:dataframe
Apr 21, 2023
Merged

Profiling corrected.#526
bosilca merged 2 commits intoICLDisco:masterfrom
josephjohnjj:dataframe

Conversation

@josephjohnjj
Copy link
Copy Markdown
Contributor

In Parsec Trace Table format V2 the information was stored incorrectly.

In Parsec Trace Table format V2 the information was stored incorrectly.
@josephjohnjj josephjohnjj requested a review from a team as a code owner April 20, 2023 05:30
@omor1
Copy link
Copy Markdown
Contributor

omor1 commented Apr 20, 2023

tools/profiling/dbpreader.c seems to have been committed extraneously.
To clarify, this fixes a bug introduced by #432 that causes the PTT v2 format to be saved incorrectly if only one thread is used; the event_infos dictionary was being dropped.

Copy link
Copy Markdown
Contributor

@therault therault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation before merging. Otherwise LGTM.

Comment thread tools/profiling/dbpreader.c
@bosilca bosilca merged commit 960a1e0 into ICLDisco:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants