Skip to content

Tear-down parsec_ce after high-level communication#549

Merged
bosilca merged 1 commit intoICLDisco:masterfrom
devreal:fix-ce-teardown
Jun 2, 2023
Merged

Tear-down parsec_ce after high-level communication#549
bosilca merged 1 commit intoICLDisco:masterfrom
devreal:fix-ce-teardown

Conversation

@devreal
Copy link
Copy Markdown
Contributor

@devreal devreal commented May 26, 2023

The finalization order is important: parsec_remote_dep_fini finalizes the high-level remote dependency infrastructure (e.g., progress thread), remote_dep_ce_fini tears-down data structures on top of the comm engine (queues). Only then can we finalize the comm engine itself.

Also fixes some weird casts that lead to strange output.

Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
@devreal devreal requested a review from a team as a code owner May 26, 2023 14:50
@abouteiller
Copy link
Copy Markdown
Contributor

Can you document in the PR description what problem it solves

@devreal
Copy link
Copy Markdown
Contributor Author

devreal commented May 26, 2023

@abouteiller Done 👍

@bosilca
Copy link
Copy Markdown
Contributor

bosilca commented May 26, 2023

@devreal I confirm this is the correct order. parsec_remote_dep_fini must be first because it is the blocking function that signal the communication engine to turn off. remote_dep_ce_fini can be next as it unregister the AM for activate and get_data and release the memory management constructs, so it needs the communication engine off.

@bosilca bosilca merged commit db7dfb5 into ICLDisco:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants