Skip to content

Add capability of saving GPU statistics and printing diff vs saved stats#558

Merged
abouteiller merged 1 commit intoICLDisco:masterfrom
abouteiller:new/diffable-stats
Jan 25, 2024
Merged

Add capability of saving GPU statistics and printing diff vs saved stats#558
abouteiller merged 1 commit intoICLDisco:masterfrom
abouteiller:new/diffable-stats

Conversation

@abouteiller
Copy link
Copy Markdown
Contributor

  1. new API parsec_devices_save_statistics fills up an array of statistics for later use
  2. new API parsec_devices_print_statistics prints the diff between start_stats (as obtained in 1.) and the current internal stats
  3. new API parsec_devices_free_statistics deallocate the array obtained from save_statistics.

This is to support customizable reporting of stats, see ICLDisco/dplasma#89

@abouteiller abouteiller requested a review from a team as a code owner June 22, 2023 18:08
@abouteiller abouteiller self-assigned this Jun 22, 2023
@abouteiller abouteiller added enhancement New feature or request high priority This is an important feature API Add Addition to the public API (version minor bump) labels Jun 22, 2023
@abouteiller abouteiller added this to the v4.0 milestone Jan 12, 2024
Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
@devreal
Copy link
Copy Markdown
Contributor

devreal commented Jan 22, 2024

Is this a public API? Are we removing an old public API, breaking existing codes? Can both coexist?

@abouteiller
Copy link
Copy Markdown
Contributor Author

The new 3 APIs in the .h are public, the old 2 APIs were private (and still exist, called from parsec_finalize)

@abouteiller abouteiller merged commit abc1d2d into ICLDisco:master Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Add Addition to the public API (version minor bump) enhancement New feature or request high priority This is an important feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants