Discover atomic support for __int128_t.#587
Merged
bosilca merged 3 commits intoICLDisco:masterfrom Nov 6, 2023
Merged
Conversation
therault
approved these changes
Oct 26, 2023
bosilca
force-pushed
the
topic/cmake_using_gcc_instead_cc
branch
from
6395698 to
df64e8e
Compare
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
topic/cmake_using_gcc_instead_cc
branch
from
df64e8e to
222faab
Compare
Contributor
|
Looks like that didn't help |
bosilca
force-pushed
the
topic/cmake_using_gcc_instead_cc
branch
from
39f2506 to
b2e54d4
Compare
bosilca
changed the title
bosilca
force-pushed
the
topic/cmake_using_gcc_instead_cc
branch
from
b9ef3e7 to
c69df0f
Compare
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
devreal
reviewed
Nov 4, 2023
bosilca
force-pushed
the
topic/cmake_using_gcc_instead_cc
branch
from
c69df0f to
9993a2f
Compare
devreal
reviewed
Nov 6, 2023
devreal
reviewed
Nov 6, 2023
Use modern detection macros/generics (atomic_is_lock_free and __has_builtin) to check if atomic operations are possible without locks on __int128_t. If not, fall back to a in-house lock version of the LIFO (without the use of _Atomic types). Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
topic/cmake_using_gcc_instead_cc
branch
from
9993a2f to
79d426e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our detection of atomic operations on 128 bits was incorrect, resulting in a conflict with compilers with proper support for _Atomic. The conflict arise from the fact that our detection thought that 128 bits atomic lock-less operations were available, but the compiler decided not to use them in the lifo (even with the correct compilation flags).
Fixes #586.