cmake logic fixes for level zero and half-installed systems#596
Merged
therault merged 1 commit intoICLDisco:masterfrom Nov 15, 2023
Merged
cmake logic fixes for level zero and half-installed systems#596therault merged 1 commit intoICLDisco:masterfrom
therault merged 1 commit intoICLDisco:masterfrom
Conversation
…erant of badly installed systems
bosilca
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix level-zero, ze_loader and dpcpp discovery to be a little more tolerant of badly installed systems.
Due to a bug in the package config files distributed on many systems, it's not because find_level_zero is true after a pkg-config that we can indeed compile and link with ze_loader (finding ze_loader does not solve the problem in these systems). This issues a warning and points how to fix the issue if this status is found during configuration.
Be also a little more tolerant to half-installed systems (e.g. find ze_loader and ze_api.h, but not find dpcpp: allow the support of level_zero devices anyway, but do not allow the generation of dpcpp code).