Make sure the w2r task has a stageout set#604
Merged
therault merged 1 commit intoICLDisco:masterfrom Dec 4, 2023
Merged
Conversation
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
bosilca
approved these changes
Dec 4, 2023
therault
approved these changes
Dec 4, 2023
Contributor
Author
|
Many moons ago there was this commit that removed the stage_out: e8a383f Commit says: I'm confused. |
Contributor
|
That commit was incorrect. It might have started from a good intention, make sure that w2r tasks do not have a stage_in, but it went haywire on the stage_out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIU, the w2r uses the stage-out mechanism to move data is meant to be evicted from the device. It should have a stage-out function set to do that.