Skip to content

cmakery: let find_package find HIP v6 #652

Merged
abouteiller merged 1 commit intoICLDisco:masterfrom
abouteiller:bugfix/hip-version-detect
May 16, 2024
Merged

cmakery: let find_package find HIP v6 #652
abouteiller merged 1 commit intoICLDisco:masterfrom
abouteiller:bugfix/hip-version-detect

Conversation

@abouteiller
Copy link
Copy Markdown
Contributor

@abouteiller abouteiller commented May 16, 2024

and check for HIP<v5 in another way as the cmake blessed way is broken.

@abouteiller abouteiller self-assigned this May 16, 2024
@abouteiller abouteiller added the compat Improves compatibility with hardware/clients label May 16, 2024
@abouteiller abouteiller added this to the v4.0 milestone May 16, 2024
@abouteiller abouteiller marked this pull request as ready for review May 16, 2024 19:15
@abouteiller abouteiller requested a review from a team as a code owner May 16, 2024 19:15
devreal
devreal approved these changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@devreal devreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abouteiller!

@abouteiller abouteiller merged commit ac20972 into ICLDisco:master May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bosilca bosilca bosilca approved these changes

@devreal devreal devreal approved these changes

Assignees

@abouteiller abouteiller

Labels

compat Improves compatibility with hardware/clients

Projects

None yet

Milestone

v4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@abouteiller @bosilca @devreal