show-caps: don't report flops for unknown cuda devs, report peer access#672
Merged
abouteiller merged 2 commits intoICLDisco:masterfrom Oct 10, 2024
Merged
Conversation
Contributor
|
Right, a whole lot of code move for a small benefit. I find it strange that we now query a device capabilities in |
report simd cpu type if found uniform output for show_caps
283fbf2 to
342a8ea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
show-caps:
The diff looks bigger that what it actually is because I had to move the cuda show_caps to after
all_devices_attachedto be able to report peer-access, so its mostly copy pasting fromcuda_module_inittoall_devices_attached