Skip to content

Comments

Feature: Add Timeseria Model Integration + Conversion Utils#65

Merged
sarusso merged 31 commits intodevelopfrom
feature/timeseria_models
Dec 10, 2025
Merged

Feature: Add Timeseria Model Integration + Conversion Utils#65
sarusso merged 31 commits intodevelopfrom
feature/timeseria_models

Conversation

@clarasaja
Copy link
Collaborator

@clarasaja clarasaja commented Dec 9, 2025 •
edited by sarusso
Loading

This PR introduces the initial integration of Timeseria into the project, including model import structure, conversion utilities.

Main Changes

  1. Added base structure for Timeseria anomaly detectors (TimeseriaAnomalyDetector) to base.py according to Timeseria models folder / files #59
  2. Added initial detectors:
  • PeriodicAverage (stat)
  • Linear Regression (ml)
  • LSTM (dl)
  1. Implemented conversion functions between timeseries and timeseries_df, including several fixes (timestamp handling, round-trip consistency).
  2. Implemented as a thin wrapper / pass-through of fit() and apply() methods from Timeseria. Apply methods also use conversion to timeseries and re-conversion back to timeseries df to handle the wrap
  3. Added set and get methods of apply parameters!

@clarasaja clarasaja changed the title Feature: Add Timeseria Model Integration + Conversion Utils + Base Anomaly Detectors Feature: Add Timeseria Model Integration + Conversion Utils Dec 9, 2025
sarusso
sarusso requested changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@sarusso sarusso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just a few minor fixes before we merge (also please rebase)

@clarasaja
Create base structure to import model from timeseria
0c8908e
@clarasaja
Set up import (timeseria datastructure, pandas, logger)
218d372
@clarasaja
Add convert timeseries df and back in utils and its test (test fail).…
37d75f4 
… Modify plot_timeseries_df using this functions
@clarasaja
Re-run notebook examples generator
8959f1c
@clarasaja
Remove comments
4ceaf36
@clarasaja
Fix conversion and back conversion froma timeseries
fe4e514
@clarasaja
Fix a bug with timeseries time
3f7da2a
@clarasaja
Add conversion from timeseries_df to timeseries and back conversion i…
dfdfec1 
…n the TimeseriaAnomalyDetector class
@clarasaja
Remane timeseriamodel in basetimeseriamodel
7fe9e5a
@clarasaja
Add fit fucntion for a generic TimeseriaAnomalyDetector and generaliz…
50506d3 
…e apply. Apply also Fit for implementing but will be modified
@clarasaja
Import timeseria model using an alias (avoid conflict)
c11cbbe
@clarasaja
Fix indendetation error
b834c23
@clarasaja
Add NotImplementedError on missing model
d5cb1c0
@clarasaja
Add fit on PeriodicAverageAnomalyDetector
91cbd47
@clarasaja
Move model chek on fit and ply functions
ad776f9
@clarasaja
Remove unusefull override of fit and apply
c89cb6a
@clarasaja
Add docs
6cf7090
@clarasaja
Add and initilize model test file
a6273ac
@clarasaja
Remove fit from apply function
f2c526c
@clarasaja
Add test for PeriodicAverageAnomalyDetector and TimeseriaAnomalyDetector
c704766
@clarasaja
Change test timeseries_df, now it is generating using generate_timese…
08a6ee7 
…ries_df from utils.py
@clarasaja
Add LSTM
2a911ba
@clarasaja
Refactor model_class implementation add Linear Regression
1a736a3
@clarasaja
Move TimeseriaAnomalyDetector in base.py
dbc7f0f
@clarasaja
Create Timeseria anomaly detector files and folders
bd6fabe
@clarasaja
Rename files
5105303
@clarasaja
Change ts in timestap in convert_timeseries_to_timeseries_df function…
502e3f5 
… in utils.py
@clarasaja
Added set and get methods of apply parameters
b092c4e
@clarasaja clarasaja force-pushed the feature/timeseria_models branch from d6bab5d to b092c4e Compare December 10, 2025 20:15
@clarasaja
Copy link
Collaborator Author

clarasaja commented Dec 10, 2025

modified and rebased @sarusso

@sarusso sarusso merged commit 8864659 into develop Dec 10, 2025
2 checks passed
@sarusso sarusso deleted the feature/timeseria_models branch December 12, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarusso sarusso sarusso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clarasaja @sarusso