Scaling 201#167
Conversation
| "\n", | ||
| "## Introduction\n", | ||
| "\n", | ||
| "This notebook is intended to give the user further insight into how the scaling toolbox can be used to improve robustness. By the end of this study, the user should understand:\n", |
There was a problem hiding this comment.
Should note that this is intended to be a follow-up of the previous scaling tutorial, and should provide a hyperlink to it
There was a problem hiding this comment.
Do we have an example of an example notebook hyperlinking to another example notebook? I checked several notebooks, but they only had external links.
There was a problem hiding this comment.
Here is an example from WaterTAP:
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com> Co-authored-by: dallan-keylogic <88728506+dallan-keylogic@users.noreply.github.com>
dallan-keylogic
left a comment
dallan-keylogic
left a comment
There was a problem hiding this comment.
For some reason Github held these comments.
| "id": "b8486746-111b-4df6-82f5-aeabe5bc2211", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "The `get_sum_terms_nominal_values` method in `CustomScalerBase` which uses an expression walker to go through an expression to return a list of the expected magnitude (or \"nominal value\") of all additive terms in the expression based on the scaling factors for the variables involved. For example, suppose we have an expression\n", |
There was a problem hiding this comment.
It might be too far into the weeds, but considering how central the expression walker is to the new scaling tools, I think we need to warn the users about its limitations somehow.
Maybe the best thing would be to have the walker itself look for "dangerous" operations and then raise an Exception if the user hasn't set some "I know the risks" setting.
| "\n", | ||
| "## Introduction\n", | ||
| "\n", | ||
| "This notebook is intended to give the user further insight into how the scaling toolbox can be used to improve robustness. By the end of this study, the user should understand:\n", |
There was a problem hiding this comment.
Do we have an example of an example notebook hyperlinking to another example notebook? I checked several notebooks, but they only had external links.
MarcusHolly
left a comment
MarcusHolly
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround on this Doug. I will approve under the assumption that you'll address the issue with the condition number tests
3 participants
Supplemental tutorial notebook for scaling.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--167.org.readthedocs.build/en/167/