Fix loss of precision when converting float to int#39
Merged
nicktelford merged 1 commit intomasterfrom Feb 12, 2025
Merged
Conversation
When calling `.int()` on a floating-point number, we were incorrectly
marshalling to a 32-bit integer (aka. `Int`), instead of a 64-bit integer (aka.
`Long`), which could result in the result being bounded at `2147483647`
(the maximum signed 32-bit integer) unnecessarily.
Since all "integers" in IDML are 64-bit, there's no reason to marshall a
floating point number to a 32-bit number.
Example:
```
json> { "foo": 1739180023809489.0 }
~> bar = foo.int()
..
{
"bar" : 2147483647
}
```
Changing to `toLong` yields this result:
```
json> { "foo": 1739180023809489.0 }
~> bar = foo.int()
..
{
"bar" : 1739180023809489
}
```
This should not cause any regressions, as it is unlikely that any users
are depending on this "bounding" behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
.int()on a floating-point number, we were incorrectlymarshalling to a 32-bit integer (aka.
Int), instead of a 64-bit integer (aka.Long), which could result in the result being bounded at2147483647(the maximum signed 32-bit integer) unnecessarily.
Since all "integers" in IDML are 64-bit, there's no reason to marshall a
floating point number to a 32-bit number.
Example:
Changing to
toLongyields this result:This should not cause any regressions, as it is unlikely that any users
are depending on this "bounding" behaviour.