Skip to content

add readme#1

Merged
zzantozz merged 5 commits intomasterfrom
readme
Mar 4, 2021
Merged

add readme#1
zzantozz merged 5 commits intomasterfrom
readme

Conversation

@zzantozz
Copy link
Copy Markdown
Contributor

Start with a readme that documents the intents and goals of the
project.

Start with a readme that documents the intents and goals of the
project.
Comment thread README.md Outdated
things in the way.

1. Create a file in your project named `rax-docs`, and add the content
from https://github.com/IDPLAT/rax-docs/blob/master/rax-docs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using a defined hyperlink, not a bare address.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md Outdated

After obtaining the toolkit via either `install`ing or `get`ting it,
you have to run `./rax-docs setup` to build your local dev
environment. This builds a Docker image locally to act as an isolated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...builds a local Docker image...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md Outdated
environment. This builds a Docker image locally to act as an isolated
environment.

This toolkit is meant to feel very similar to the original. In general,
Copy link
Copy Markdown
Contributor

@cringdahl cringdahl Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a header here, something like "Legacy Users" (should be line 81, apologies)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption going into this is that legacy users will be the (initial) primary group of users.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md Outdated
How it works
============

The goal of this toolkit is to make one tool that everyone can use to
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of a run on. Can this be more succinctly said or split into two more more thoughts?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md Outdated
as well as how they run commands to build, test, and publish their
docs. Build automaters such as Jenkins will also use it this way.

This wrapper script is the part of the project that is distributed
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal preference, I'd replace 'This wrapper script' with rax-docs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md Outdated
Testing and debugging
=====================

There are bats tests for the script. For easier testing, there are a few
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one variable listed here, but "there are a few".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@samwar samwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use some minor tweaks.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
To fill this role, the wrapper script is only responsible for
retrieving the main body of the toolkit by cloning the repo from
GitHub. After cloning, it delegates all other commands to scripts in
the local, cloned directory.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think grammatically you can omit the ,

Suggested change
the local, cloned directory.
the local cloned directory.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is two adjectives describing the same noun. The comma is required.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always thought the rule was two describing adjectives didn't need the comma, but three-plus did.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might actually sound better as

Suggested change
the local, cloned directory.
the locally cloned directory.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. i had the same thought: change an adjective to an adverb, and the problem goes away!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Testing became too tricky, even with the SOURCE_DIR option. I changed
it to completely stub out git. This variable isn't needed anymore.
@zzantozz
Copy link
Copy Markdown
Contributor Author

zzantozz commented Mar 4, 2021

In the interest of getting a landing page out there for people to start looking at, I'm going to merge this. Feel free to point out additional changes that need to be made or open PRs. This was just a first draft and certainly still needs improvement.

@zzantozz zzantozz merged commit 4bd431d into master Mar 4, 2021
@zzantozz zzantozz deleted the readme branch March 4, 2021 20:39
@zzantozz zzantozz added the feature New feature or request label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants