Conversation
zzantozz
force-pushed
the
docker-it
branch
3 times, most recently
from
78d1fb8 to
af07e54
Compare
As I continue testing, it becomes apparent that it'll be useful to divide unit (fast) tests from integration (maybe slow) tests. Building the docker image is one such test. It can take quite a while, and it also has the side effect of overwriting your local image, so it's not one you want to include in the "run all the time" test suite. This adds initial docker image tests as the first integration test.
samwar
approved these changes
Mar 17, 2021
zzantozz
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I continue testing, it becomes apparent that it'll be useful to
divide unit (fast) tests from integration (maybe slow) tests. Building
the docker image is one such test. It can take quite a while, and it
also has the side effect of overwriting your local image, so it's not
one you want to include in the "run all the time" test suite.
This adds initial docker image tests as the first integration test.