Merged
Conversation
zzantozz
force-pushed
the
wrapper-checks-out-version
branch
from
da9787a to
97f3315
Compare
samwar
reviewed
Mar 22, 2021
| [ "${lines[-1]}" = "install command completed" ] | ||
| [ $status -eq 0 ] | ||
| [ "$(cat git-input)" = "clone git@github.com:IDPLAT/rax-docs.git .rax-docs/repo" ] | ||
| [ "$(head -1 git-input)" = "clone git@github.com:IDPLAT/rax-docs.git .rax-docs/repo" ] |
Member
There was a problem hiding this comment.
I think this needs to be cloned using the https right?
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right. Copy/paste error
zzantozz
force-pushed
the
wrapper-checks-out-version
branch
from
97f3315 to
1f303fa
Compare
All this time, the wrapper has been leaving the version checkout up to the internal script, which means the wrapper checks out master and runs *that* version of the internal script, which is clearly wrong. This moves the initial version checkout to the wrapper so things will work as expected. The internal script still has lots of other version management things to do. I think they'll work as expected still.
zzantozz
force-pushed
the
wrapper-checks-out-version
branch
from
1f303fa to
dee8444
Compare
samwar
approved these changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All this time, the wrapper has been leaving the version checkout up to
the internal script, which means the wrapper checks out master and
runs that version of the internal script, which is clearly
wrong. This moves the initial version checkout to the wrapper so things
will work as expected.
The internal script still has lots of other version management things
to do. I think they'll work as expected still.