Skip to content

Content snackbar and page 3 layout update #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amiraliemami merged 11 commits into from
Aug 30, 2024
Merged

Content snackbar and page 3 layout update #419

amiraliemami merged 11 commits into from
Aug 30, 2024

Conversation

@amiraliemami
Copy link
Collaborator

@amiraliemami amiraliemami commented Aug 30, 2024 •
edited
Loading

Reviewer: @markbotterill
Estimate: 15mins

Ticket

Fixes: Cleanup

Description

Changes

  • Contents page:
    • Updated snackbar to use localStorage instead of relying on URL parameters. This means that snackbars don't keep appearing on page reloads.
  • dashboard page 3
    • Rename dashboard page 3 to "Query Topics" since we're not doing content gaps yet and updated the logos to nicer ones
    • Change layout to use Paper and Box instead of Grids
    • AI box doesn't show if discovery has never been run
    • Button is aware of whether discovery has been run or not.

How has this been tested?

  • dev

Future tasks

  • Save the refreshing state of the discovery button to localStorage (or some other way of tracking that the process is still ongoing) so that if the user changes tab / leaves and comes back the button still shows that it's still working...

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts

markbotterill
markbotterill approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@markbotterill markbotterill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@amiraliemami amiraliemami merged commit 8677214 into main Aug 30, 2024
@amiraliemami amiraliemami deleted the snackbar-update branch August 30, 2024 09:34
@amiraliemami amiraliemami restored the snackbar-update branch August 30, 2024 12:10
@amiraliemami amiraliemami deleted the snackbar-update branch August 30, 2024 12:13
amiraliemami added a commit that referenced this pull request Aug 30, 2024
@amiraliemami @markbotterill
Content snackbar and page 3 layout update (#419)
827ec3c 
* Remove content ID from snackbar messages

* Add slide-in and clean disappear to snackbars on content page

* Make content edit/creation snackbar independent of URL

* Update to "Query Topics" and update logos

* Refactor dashboard page 3 layout components

* Hide AI summary box if discovery has never been run

* Button now says Run Discovery if never ran, "Rerun" if ran before. Updated to LoadingButton with magic wand logo.

---------

Co-authored-by: Mark Botterill <markbotters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markbotterill markbotterill markbotterill approved these changes

@sidravi1 sidravi1 Awaiting requested review from sidravi1 sidravi1 is a code owner

@suzinyou suzinyou Awaiting requested review from suzinyou suzinyou is a code owner

@lickem22 lickem22 Awaiting requested review from lickem22 lickem22 is a code owner

@Tanmay-97 Tanmay-97 Awaiting requested review from Tanmay-97

@tonyzhao6 tonyzhao6 Awaiting requested review from tonyzhao6 tonyzhao6 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amiraliemami @markbotterill